From: Sebastian Keller Date: Mon, 14 Dec 2020 14:51:46 +0000 (+0100) Subject: shell/network-agent: Fix setting leak in get_secrets_keyring_cb X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~616^2^2~662 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=f0deb03bd42478640c211931a2857a4b05631fc0;p=gnome-shell.git shell/network-agent: Fix setting leak in get_secrets_keyring_cb The setting GVariant was not consumed by anything in the VPN case. Part-of: --- diff --git a/src/shell-network-agent.c b/src/shell-network-agent.c index 9524fe520..af5dfbb33 100644 --- a/src/shell-network-agent.c +++ b/src/shell-network-agent.c @@ -243,7 +243,7 @@ get_secrets_keyring_cb (GObject *source, GList *l; gboolean secrets_found = FALSE; GVariantBuilder builder_setting, builder_connection; - GVariant *setting; + g_autoptr (GVariant) setting = NULL; items = secret_service_search_finish (NULL, result, &secret_error); @@ -303,7 +303,7 @@ get_secrets_keyring_cb (GObject *source, } g_list_free_full (items, g_object_unref); - setting = g_variant_builder_end (&builder_setting); + setting = g_variant_ref_sink (g_variant_builder_end (&builder_setting)); /* All VPN requests get sent to the VPN's auth dialog, since it knows better * than the agent about what secrets are required. Otherwise, if no secrets